fix(network): use goroutines for sending streams #1365
Merged
+50
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
+ Coverage 76.05% 77.32% +1.26%
==========================================
Files 206 233 +27
Lines 10672 11941 +1269
==========================================
+ Hits 8117 9233 +1116
- Misses 2169 2290 +121
- Partials 386 418 +32 |
themantre
reviewed
Jun 25, 2024
network/network.go
Outdated
| go func() { | ||
| err := n.gossip.Broadcast(msg, topicID) | ||
| if err != nil { | ||
| n.logger.Error("error on broadcasting msg", "error", err) |
themantre
approved these changes
Jun 25, 2024
themantre
pushed a commit
that referenced
this pull request
Jun 25, 2024
themantre
pushed a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had a known issue that happened occasionally. Sometimes
the nodes would lag for a minute and then start syncing. This PR fixes this issue.
The main reason was that once
SendToblocked (for any reason), the receiving loop also got stuck.Here, we send messages asynchronously to ensure the receiving loop doesn't get blocked.