Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated proposals #121

Merged
merged 28 commits into from
Apr 2, 2021
Merged

Duplicated proposals #121

merged 28 commits into from
Apr 2, 2021

Conversation

themantre
Copy link
Contributor

@themantre themantre commented Mar 28, 2021

  • Detect and keeping duplicated votes
  • Check if more than 1f power voted for null
  • Fix broken tests
  • Fix data race issue for Fingerprint method (logger)

@themantre themantre force-pushed the duplicated_proposals branch from c482bf6 to 36d6ffd Compare April 1, 2021 07:12
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #121 (61ed13b) into main (a452bde) will increase coverage by 0.08%.
The diff coverage is 89.09%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   81.07%   81.16%   +0.08%     
==========================================
  Files         102      102              
  Lines        4777     4725      -52     
==========================================
- Hits         3873     3835      -38     
+ Misses        653      639      -14     
  Partials      251      251              

@themantre themantre force-pushed the duplicated_proposals branch from e8d1715 to 63410de Compare April 1, 2021 07:54
@themantre themantre force-pushed the duplicated_proposals branch from 63410de to b221256 Compare April 1, 2021 07:59
@themantre themantre force-pushed the duplicated_proposals branch from 2083ccc to 0167c02 Compare April 1, 2021 08:39
@themantre themantre force-pushed the duplicated_proposals branch from c20ffd6 to 491c540 Compare April 1, 2021 11:24
@themantre themantre force-pushed the duplicated_proposals branch from ad7748d to a1e141c Compare April 1, 2021 16:59
@themantre themantre force-pushed the duplicated_proposals branch from ec566d1 to 3e3668f Compare April 2, 2021 10:25
@themantre themantre force-pushed the duplicated_proposals branch from 3e3668f to f63e316 Compare April 2, 2021 10:36
@themantre themantre merged commit b708bb9 into main Apr 2, 2021
@b00f b00f deleted the duplicated_proposals branch April 27, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant