refactor: move fee calculation logic to execution package #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
- Coverage 81.48% 81.43% -0.05%
==========================================
Files 179 179
Lines 9532 9528 -4
==========================================
- Hits 7767 7759 -8
- Misses 1381 1387 +6
+ Partials 384 382 -2 |
kehiy
approved these changes
Apr 4, 2024
kehiy
changed the title
kehiy
changed the title
b00f
changed the title
kehiy
approved these changes
Apr 5, 2024
execution/execution_test.go
Outdated
| amount amount.Amount | ||
| fee amount.Amount | ||
| expectedFee amount.Amount | ||
| expectedErr bool |
There was a problem hiding this comment.
we can change it to: expectErr
ambersun1234
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes related to fee calculation: