feat: Add GetNewAddress gRPC API #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambersun1234
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
- Coverage 81.44% 81.42% -0.02%
==========================================
Files 179 179
Lines 9500 9531 +31
==========================================
+ Hits 7737 7761 +24
- Misses 1381 1384 +3
- Partials 382 386 +4 |
ambersun1234
force-pushed
the
feature/add-get-new-address-api
branch
from
fa8d4ab
to
4c9a9e2
Compare
b00f
approved these changes
Apr 4, 2024
www/grpc/proto/wallet.proto
Outdated
|
|
||
| // Enum for the address type. | ||
| enum AddressType { | ||
| ADDRESS_TYPE_ADDRESS_TYPE_TREASURY = 0; |
There was a problem hiding this comment.
I think it can be ADDRESS_TYPE_TREASURY or even TREASURY. Same for other values
| // Response message containing the new address. | ||
| message GetNewAddressResponse { | ||
| string wallet_name = 1; | ||
| AddressInfo address_info = 2; |
There was a problem hiding this comment.
Please comment these lines.
They will be included in the automatically generated documents.
ambersun1234
force-pushed
the
feature/add-get-new-address-api
branch
from
4c9a9e2
to
115aa71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR Add
GetNewAddressAPI endpoint