Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add basic auth authentication for securing grpc #1162

Merged
merged 19 commits into from
Mar 12, 2024
Merged

feat: add basic auth authentication for securing grpc #1162

merged 19 commits into from
Mar 12, 2024

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Mar 11, 2024

@Ja7ad
Copy link
Contributor Author

Ja7ad commented Mar 12, 2024

@b00f @kehiy @amirvalhalla I fix conflict, please review it.

@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024 •
edited
Loading

Codecov Report

Merging #1162 (12777e8) into main (f51239e) will decrease coverage by 0.55%.
The diff coverage is 44.87%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
- Coverage   81.26%   80.71%   -0.55%     
==========================================
  Files         175      177       +2     
  Lines        9277     9413     +136     
==========================================
+ Hits         7539     7598      +59     
- Misses       1377     1443      +66     
- Partials      361      372      +11

b00f
b00f approved these changes Mar 12, 2024
View reviewed changes
util/htpasswd/htpasswd.go Outdated Show resolved Hide resolved
util/htpasswd/htpasswd_test.go Outdated Show resolved Hide resolved
util/htpasswd/htpasswd_test.go Outdated Show resolved Hide resolved
util/htpasswd/htpasswd.go Outdated Show resolved Hide resolved
util/htpasswd/htpasswd.go Outdated Show resolved Hide resolved
www/grpc/config.go Show resolved Hide resolved
config/example_config.toml Outdated Show resolved Hide resolved
config/example_config.toml Outdated Show resolved Hide resolved
www/grpc/middleware_test.go Outdated Show resolved Hide resolved
www/grpc/middleware_test.go Show resolved Hide resolved
b00f
b00f approved these changes Mar 12, 2024
View reviewed changes
util/htpasswd/htpasswd_test.go Show resolved Hide resolved
@b00f b00f merged commit 9fbab2f into pactus-project:main Mar 12, 2024
11 of 12 checks passed
@b00f
Copy link
Collaborator

b00f commented Mar 12, 2024

@Ja7ad merged with thanks
Now, we can add a post on website to explain: "How to secure gRPC using basic authentication?"

Ja7ad added a commit to pactus-project/PIPs that referenced this pull request Mar 12, 2024
@Ja7ad
chore: update pip status to final
a9c9f17 
Fixed pactus-project/pactus#1162
@Ja7ad Ja7ad mentioned this pull request Mar 12, 2024
Merged
Ja7ad added a commit to pactus-project/PIPs that referenced this pull request Mar 12, 2024
@Ja7ad
chore: update pip status to final (#97)
8febd9f 
Fixed pactus-project/pactus#1162
@Ja7ad Ja7ad deleted the feat/pip-20 branch March 16, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b00f b00f b00f approved these changes

@kehiy kehiy Awaiting requested review from kehiy

@amirvalhalla amirvalhalla Awaiting requested review from amirvalhalla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ja7ad @b00f