fix: add error type for invalid configs #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00f
requested changes
Mar 8, 2024
b00f
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
+ Coverage 81.27% 81.33% +0.05%
==========================================
Files 173 175 +2
Lines 9272 9277 +5
==========================================
+ Hits 7536 7545 +9
+ Misses 1375 1372 -3
+ Partials 361 360 -1 |
b00f
approved these changes
Mar 8, 2024
|
@nagarajmanjunath please fix the linting issues |
|
@nagarajmanjunath update the PR description |
vlasfama
changed the title
b00f
approved these changes
Mar 11, 2024
b00f
changed the title
|
@nagarajmanjunath Merged with Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR defines
ConfigErrortype for internal modules.Related issue(s)
It partially fixes issue #315