fix(sync): fix concurrent map read-write crash #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
==========================================
+ Coverage 81.23% 81.31% +0.07%
==========================================
Files 173 173
Lines 9211 9214 +3
==========================================
+ Hits 7483 7492 +9
+ Misses 1369 1365 -4
+ Partials 359 357 -2 |
themantre
force-pushed
the
crash-concurrent-map-write
branch
from
ace0b0c
to
eca0137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A concurrent map iteration and map write crash occurred when
IteratePeerswas called by gRPC and the Peers map was updated simultaneously. This patch fixes this crash.