-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grpc): update swagger API to version 1.1 #1106
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
=======================================
Coverage 81.40% 81.40%
=======================================
Files 173 173
Lines 9217 9217
=======================================
Hits 7503 7503
+ Misses 1360 1359 -1
- Partials 354 355 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just have one question. What's the purpose of the pactus
prefix instead of v1
, and why we removed the v1
prefix? Isn't that helpful when we add the next versions over time?
I saw that swagger also has version, we bump it to v1.1 in this PR |
what about SDKs and users that use these endpoints on code? they don't work with Swagger in code and they don't have access to the Swagger version. |
Even we add version to API, they still need to update their code. So this version is not really helpful for them |
what if they want to support different Pactus RPC versions? For example: PactusSDK => RPCV1, RPCV2 ... |
To keep things simple, we only support one version, and it is the latest one. Imagine in Pactus version 1.2.0 we have RPCV1, and in version 1.3.0 we have RPCV2. |
fb5bd44
to
90422f9
Compare
Description
This PR updates the Swagger APIs to version 1.1. In this new version we follow this convention:
pactus