Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(features:main:theme): add theme manager for switch between dark and light themes #33

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

esmaeil-ahmadipour
Copy link
Collaborator

No description provided.

@esmaeil-ahmadipour esmaeil-ahmadipour added the feature Add/Create new feature label Nov 28, 2024
@esmaeil-ahmadipour esmaeil-ahmadipour self-assigned this Nov 28, 2024
@esmaeil-ahmadipour esmaeil-ahmadipour linked an issue Nov 28, 2024 that may be closed by this pull request
@esmaeil-ahmadipour esmaeil-ahmadipour added the review request High priority, please review quickly label Nov 28, 2024
fontSize: 36,
height: 52 / 36,
leadingDistribution: TextLeadingDistribution.even,
),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a method to reduce code duplication. For ex

static TextStyle _createCommonTextStyle({
required String fontFamily,
required Color color,
required FontStyle fontStyle,
required FontWeight fontWeight,
required double fontSize,
required double height,
required TextLeadingDistribution leadingDistribution,
}) {
return TextStyle(
fontFamily: fontFamily,
color: color,
fontStyle: fontStyle,
fontWeight: fontWeight,
fontSize: fontSize,
height: height,
leadingDistribution: leadingDistribution,
);
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phoenixit99 , Understood. This is a valid point, and I’ll address it in a separate issue at a more appropriate time, aligned with issue #34

color: SurfacePallet.light.surface3,
fontStyle: FontStyle.normal,
fontWeight: FontWeight.w400,
fontSize: 32,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider defining the font size as a constant

static const fontSizes = FontSizes(
displaySmall: 16,
headlineLarge: 36,
// ... other sizes
);

Copy link
Collaborator Author

@esmaeil-ahmadipour esmaeil-ahmadipour Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all the review items are related to text styles, we already have a dedicated issue addressing this.
We can finishing this merge request.


@phoenixit99

Copy link

@phoenixit99 phoenixit99 Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.got it. We can merge request the PR

@phoenixit99 phoenixit99 removed the review request High priority, please review quickly label Nov 29, 2024
@phoenixit99 phoenixit99 merged commit 8fcfd70 into develop Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add/Create new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Theme Management
2 participants