Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup ruby warnings #96

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

ojab
Copy link
Contributor

@ojab ojab commented Mar 27, 2022

…/json/add/regexp.rb:17: warning: method redefined; discarding old as_json
…/activesupport-7.0.2.3/lib/active_support/core_ext/object/json.rb:134: warning: previous definition of as_json was here
…/consumer_contract/interaction_v2_parser.rb:41: warning: assigned but unused variable - request
…/matching_rules/merge.rb:45: warning: assigned but unused variable - recursed
…/consumer_contract/pact_file.rb:39: warning: assigned but unused variable - e
…/consumer_contract/pact_file.rb:61: warning: mismatched indentations at 'end' with 'if' at 58

```
…/json/add/regexp.rb:17: warning: method redefined; discarding old as_json
…/activesupport-7.0.2.3/lib/active_support/core_ext/object/json.rb:134: warning: previous definition of as_json was here
…/consumer_contract/interaction_v2_parser.rb:41: warning: assigned but unused variable - request
…/matching_rules/merge.rb:45: warning: assigned but unused variable - recursed
…/consumer_contract/pact_file.rb:39: warning: assigned but unused variable - e
…/consumer_contract/pact_file.rb:61: warning: mismatched indentations at 'end' with 'if' at 58
```
@ojab
Copy link
Contributor Author

ojab commented Mar 27, 2022

First-time contributors need a maintainer to approve running workflows.

bundle exec rspec is green locally, sending to review.

@ojab ojab marked this pull request as ready for review March 27, 2022 10:13
@bethesque bethesque merged commit cee7113 into pact-foundation:master Mar 28, 2022
@bethesque
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants