refactor: replace ansicolor gem with rainbow to avoid naming collisions #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethesque
reviewed
Feb 27, 2022
|
I'm ok with this. What conflicts are you seeing? |
|
@bethesque thank you for taking a look! At the moment the conflict is localized to our specific app in that the term-ansicolor gem injects a If you are ok with this change I believe I have to open PRs for some of the support repos as well that also use this gem. Is it ok to tag you with all of them? |
Merged
This was referenced Aug 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
term-ansicolorgem injects a globalTermmodule that has a high probability of naming collision for other common class names. This PR replaces that gem with therainbowgem to avoid this issue.