chore: upgrade tree_magic_mini to 3.0.1 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm just going to get feedback from the other maintainers if forcing to GPL license is a problem. It might be better to not include the MIME database, which means Windows uses will not get the content type detection for binary data. I don't think lots of people use that anyway. |
|
Unless I am missing something, I don't think it's a good idea to make |
|
Mime detection is not important to me, getting rid of nom 6 is. This PR changes nothing about the licensing issue.. MIME removal could be handled in another PR? |
|
I'll sort it out when I get a chance to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades all of
nomto7.0.0.In order to pass tests, the
with-gpl-datafeature needed to be added.tree_magic_miniis GPL-licensed, because the MIME database is. Which in turn makes pact-reference itself GPL.Note that tree_magic_mini is already GPL-licensed at version 2.