-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish verification results with a version tag in pact-jvm-provider-spring_2.12 #823
Comments
That is a good question. The way the verifications work is they publish the results back based on the pact URL that was fetched for the test. So when you specify the tag in the test, this will point to a version of the pact file (tags are just labels to a pact file version), and the verification will be posted back against that version. That is my understanding, but @bethesque is probably the only person who really understands this stuff. |
Thanks for the quick answer. |
I need to add this to the ruby impl too, if I haven't already. While you're waiting for this feature, you can either do a curl to PUT the tag in the right place via the API, or use the pact broker client. |
+1. I really could use the above feature, in the gradle plugin implementation. |
Is there a link to the specific req in the API docs to version the provider? Don't want to tag the file just the provider version. Thanks! |
@bethesque as discussed on slack, this would help tag the provider later, but the tags info won't be part of the provider_verification_published webhook, which is I guess required if you have to retrigger can-i-deploy on consumer side. The only workaround I see at the moment is to configure a retry in can-i-deploy. |
You can always run the tagging code before you execute the pact tests. It's designed so that you tag first. |
@bethesque Do I post/put the tag to the provider to |
Hm, no unfortunately, that will tag the consumer. In the Ruby code, I've fetched the |
4.0.1 has been released |
In provider side, even if specify in JVM system properties System.setProperty("pact.provider.tag", "dev") ,the tag is not included in broker |
I think the provider tag parameter is missing in the |
Below is my code, I can publish provider version,but the tag name is not publishing to pact broker @MockBean @beforeeach
} @testtemplate @State("status endpoint is up") |
In this version provider can't send tag name to Pact broker.As you see my from code, I'am setting |
Good catch @l-lin! This should be fixed now for JUnit based tests |
Can someone tell me in which version this issue was fixed ? I am facing the same issue with my pact jvm with the pact.provider.branch argument and am looking for a solution. My organisation does not allow using any random external library, hence I have less version choices available to me. |
All versions after 3.6.15 |
Hi,
When I want to publish verification results to my pact broker I have to add:
alongside with the provider version:
My question is: How do I specify the provider tag?
I haven't seen an option to do that in pact-jvm-provider-spring or in pact-jvm-provider-junit..
The text was updated successfully, but these errors were encountered: