Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upd(insync-deb): 3.5.4.50130 -> 3.7.6.50356 #1059

Merged
merged 1 commit into from
May 8, 2022
Merged

upd(insync-deb): 3.5.4.50130 -> 3.7.6.50356 #1059

merged 1 commit into from
May 8, 2022

Conversation

Zahrun
Copy link
Contributor

@Zahrun Zahrun commented Apr 29, 2022

No description provided.

@Elsie19 Elsie19 added the Update Package Use this to request pacscript update label Apr 29, 2022
Elsie19
Elsie19 requested changes Apr 30, 2022
View reviewed changes
Copy link
Member

@Elsie19 Elsie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails on debian stable

@Zahrun
Copy link
Contributor Author

Zahrun commented May 7, 2022

Fails on debian stable

ubuntu and debian debs have different hashes. Should I remove the hash check or support only ubuntu?

@Elsie19
Copy link
Member

Elsie19 commented May 7, 2022

Fails on debian stable

ubuntu and debian debs have different hashes. Should I remove the hash check or support only ubuntu?

Add cases for different hashes.

@Zahrun Zahrun changed the title upd(insync-deb): 3.5.4.50130 -> 3.7.5.50350 upd(insync-deb): 3.5.4.50130 -> 3.7.6.50356 May 7, 2022
Elsie19
Elsie19 requested changes May 7, 2022
View reviewed changes
packages/insync-deb/insync-deb.pacscript Outdated Show resolved Hide resolved
@Zahrun Zahrun force-pushed the update branch 4 times, most recently from 6b01ff2 to 484139e Compare May 8, 2022 09:07
@Zahrun
Copy link
Contributor Author

Zahrun commented May 8, 2022 •
edited
Loading

From CI:

/var/lib/dpkg/info/insync.postinst: 135: pgrep: not found
Insync installation has finished. You may now start it.

/var/lib/dpkg/info/insync.postinst: 327: sysctl: not found
dpkg: error processing package insync (--configure):
 installed insync package post-installation script subprocess returned error exit status 127

It seems the CI debian install does not have procps package installed and that make it fail. Probably the deb lacks dependency on procps.
The installation works fine in my debian bullseye vm.

@Elsie19
Copy link
Member

Elsie19 commented May 8, 2022

Then add procps to depends

@Zahrun
Copy link
Contributor Author

Zahrun commented May 8, 2022

Then add procps to depends

Pacstall silently ignores depends for -deb packages

@Elsie19
Copy link
Member

Elsie19 commented May 8, 2022 •
edited
Loading

Oh, @D-Brox can you make a PR to fix that

Anyway I'll approve this PR, as most systems would have it installed

@Elsie19 Elsie19 merged commit 6a284a9 into pacstall:master May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elsie19 Elsie19 Elsie19 approved these changes

Assignees

@Zahrun Zahrun

Labels
Update Package Use this to request pacscript update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zahrun @Elsie19