Configuration migrations #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jpopelka
reviewed
Apr 12, 2023
Comment on lines
+356
to
+412
| dir_path = os.path.join(config_dir, dir_name) | ||
|
|
||
| Path(dir_path).mkdir(parents=True, exist_ok=True) | ||
|
|
||
| file_path = os.path.join(dir_path, repo.package_config_path) | ||
| with open(file_path, "w") as config_file: | ||
| config_file.write(repo.package_config) |
There was a problem hiding this comment.
Suggested change
| dir_path = os.path.join(config_dir, dir_name) | |
| Path(dir_path).mkdir(parents=True, exist_ok=True) | |
| file_path = os.path.join(dir_path, repo.package_config_path) | |
| with open(file_path, "w") as config_file: | |
| config_file.write(repo.package_config) | |
| dir_path = repo_store_path / dir_name | |
| dir_path.mkdir(parents=True, exist_ok=True) | |
| file_path = dir_path / repo.package_config_path | |
| file_path.write_text(repo.package_config) |
Comment on lines
+102
to
+108
| url_file = os.path.join(directory, URL_FILE_NAME) | ||
| if not os.path.isfile(url_file): | ||
| return None | ||
|
|
||
| with open(url_file) as file: | ||
| url = file.read() |
There was a problem hiding this comment.
Suggested change
| url_file = os.path.join(directory, URL_FILE_NAME) | |
| if not os.path.isfile(url_file): | |
| return None | |
| with open(url_file) as file: | |
| url = file.read() | |
| url_file = directory / URL_FILE_NAME | |
| if not url_file.is_file(): | |
| return None | |
| url = url_file.read_text() |
The script provides 3 commands (see particular command's --help for more info): 1. download-configs - to download the configs of the repos that used Packit Service in the past year 2. list-affected - to list the projects affected by particular migration 3. migrate - to update the config and create PR Related to packit#159 Related to packit/packit-service#1775
lbarcziova
force-pushed
the
config-migrations
branch
from
108b16f to
17b03b8
Compare
TomasTomecek
approved these changes
Apr 24, 2023
|
@TomasTomecek yes, agreed, I will move it to a new dedicated repo; so now the harder part, what should be the name 😀 :
|
I think this makes sense. |
|
The content of this PR was moved to the new repo, therefore closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages and help of the commands for more info
TODO: