Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post about advanced usage of specfile #987

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

nforro
Copy link
Member

@nforro nforro commented Jan 9, 2025

Copy link
Contributor

posts/specfile-advanced/index.md Outdated Show resolved Hide resolved
posts/specfile-advanced/index.md Show resolved Hide resolved
posts/specfile-advanced/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

Copy link
Contributor

Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I'll try to market this in the reports.

posts/specfile-advanced/index.md Outdated Show resolved Hide resolved
Version: %{maj_ver}.%{min_ver}.%{patch_ver}%{?rc_ver:~rc%{rc_ver}}
```

The algorithm isn't perfect and won't work in all situations, but even if it's not possible to update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you can describe how the implementation works so people can understand how you match the macros?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try, but it would be probably worth a separate blog post 🙂

Copy link
Member Author

@nforro nforro Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to describe it in 6cd88bb. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me merge it as it is, we can always do adjustments later.

Copy link
Contributor

Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

posts/specfile-advanced/index.md Outdated Show resolved Hide resolved

## More info and links

Are you interested in more details, trying the library out or even contributing?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

Signed-off-by: Nikola Forró <[email protected]>
Co-authored-by: Matej Focko <[email protected]>
Co-authored-by: František Lachman <[email protected]>
Co-authored-by: Laura Barcziová <[email protected]>
Copy link
Contributor

Copy link
Contributor

@nforro nforro added the mergeit When set, zuul wil gate and merge the PR. label Jan 11, 2025
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/2f128349ad87415287650e440a87e57f

✔️ pre-commit SUCCESS in 1m 10s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e53f200 into packit:main Jan 11, 2025
4 checks passed
@nforro nforro deleted the specfile branch January 11, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document pecularities about spec tag parsing
4 participants