-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog post about advanced usage of specfile #987
Conversation
Build succeeded. ✔️ pre-commit SUCCESS in 1m 14s |
Build succeeded. ✔️ pre-commit SUCCESS in 1m 36s |
Build succeeded. ✔️ pre-commit SUCCESS in 1m 12s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I'll try to market this in the reports.
Version: %{maj_ver}.%{min_ver}.%{patch_ver}%{?rc_ver:~rc%{rc_ver}} | ||
``` | ||
|
||
The algorithm isn't perfect and won't work in all situations, but even if it's not possible to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think you can describe how the implementation works so people can understand how you match the macros?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try, but it would be probably worth a separate blog post 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to describe it in 6cd88bb. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me merge it as it is, we can always do adjustments later.
Build succeeded. ✔️ pre-commit SUCCESS in 1m 04s |
Build succeeded. ✔️ pre-commit SUCCESS in 1m 09s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job!
|
||
## More info and links | ||
|
||
Are you interested in more details, trying the library out or even contributing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Build succeeded. ✔️ pre-commit SUCCESS in 1m 10s |
Signed-off-by: Nikola Forró <[email protected]> Co-authored-by: Matej Focko <[email protected]> Co-authored-by: František Lachman <[email protected]> Co-authored-by: Laura Barcziová <[email protected]>
Build succeeded. ✔️ pre-commit SUCCESS in 1m 13s |
Signed-off-by: Nikola Forró <[email protected]>
Build succeeded. ✔️ pre-commit SUCCESS in 1m 09s |
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 10s |
e53f200
into
packit:main
Fixes packit/specfile#278.