Document notifications.failure_comment.message #735
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 06s |
| Same as for other keys, you can define this option at the top-level, applying it to all jobs, or configure it | ||
| on a job level, enabling you to have specific messages for each job or opt not to have a message for certain | ||
| jobs. By default, no message is posted on job failure. |
There was a problem hiding this comment.
Good point with the top-level/job-level reminder. People still don't know this.
lbarcziova
force-pushed
the
failure-comment-message
branch
from
acff947 to
6cc4634
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 10s |
Implement commenting on failure based on config If there is the failure_comment_message defined in the config, notify users via comment on failure using the configured message. Comment only once per commit SHA and job (utilising check of previous identical Packit comment). Fixes #1911 TODO: Update or write new documentation in packit/packit.dev. (packit/packit.dev#735) RELEASE NOTES BEGIN We have introduced a new configuration option notifications.failure_comment.message that enables notifying users on failure via a comment using the configured message. RELEASE NOTES END Reviewed-by: Laura Barcziová Reviewed-by: František Lachman <[email protected]> Reviewed-by: Martin Pitt
|
The feature landed and was announced -- time to land this documentation as well? Thanks! |
|
@martinpitt oh sure, thanks for reminding! |
lbarcziova
force-pushed
the
failure-comment-message
branch
from
6cc4634 to
957ae8a
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 06s |
|
regate |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 06s |
|
I see it in https://packit.dev/docs/configuration/#message now, thanks! |
Related to packit/packit-service#1911
Merge once in production.