Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pull-from-upstream for non-git upstreams #2498

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented Aug 9, 2024

Fixes #2203

TODO:

  • dashboard followup

RELEASE NOTES BEGIN

pull-from-upstream is now supported also without specifying upstream_project_url in the configuration. For such cases, the upstream repository will not be detected and cloned during release syncing.

RELEASE NOTES END

@lbarcziova lbarcziova requested a review from a team as a code owner August 9, 2024 13:17
Copy link
Contributor

Copy link
Member

@majamassarini majamassarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

Copy link
Member

@nforro nforro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

- rename the attributes related to Anitya in the AnityaUpdateEvent
- introduce model for project and new version in Anitya
- utilise those for pull-from-upstream for non-git upstreams
- change the affected API
Copy link
Contributor

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Aug 13, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/b963f2982f6448ea9393ae9cb5ac84b0

✔️ pre-commit SUCCESS in 2m 14s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 30964bf into packit:main Aug 13, 2024
4 of 5 checks passed
@lbarcziova lbarcziova deleted the non-git-pull branch August 13, 2024 12:14
Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I was expecting many more changes!

🚀

(edit: forgot to submit this before the merge..;)

@@ -278,6 +278,7 @@ class ProjectEventModelType(str, enum.Enum):
release = "release"
issue = "issue"
koji_build_tag = "koji_build_tag"
anitya_version = "anitya_version"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, it looked like a version of Anitya that doesn't make sense, but it might still be worth picking another name?

Maybe anitya_project_version, or is it too verbose?

Comment on lines 106 to 108
anitya_project_id = anitya_project_name = anitya_package = project_url = (
repo_name
) = repo_namespace = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is funnily long... Not sure if I like it.. but why not. I hope the meaning is clear for everyone.

@Venefilyn
Copy link
Contributor

I'm curious, what is Anitya?

@lbarcziova
Copy link
Member Author

It is a monitoring platform for upstream projects that checks for new releases, see docs. It is used in Packit for pull-from-upstream jobs. This is how project in Anitya looks like.

@lbarcziova lbarcziova mentioned this pull request Aug 24, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow pull from upstream for non-git upstreams
5 participants