-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pull-from-upstream for non-git upstreams #2498
Support pull-from-upstream for non-git upstreams #2498
Conversation
Build succeeded. ✔️ pre-commit SUCCESS in 2m 16s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build succeeded. ✔️ pre-commit SUCCESS in 2m 14s |
- rename the attributes related to Anitya in the AnityaUpdateEvent - introduce model for project and new version in Anitya - utilise those for pull-from-upstream for non-git upstreams - change the affected API
a5f0e36
to
1996b57
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 2m 08s |
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 14s |
30964bf
into
packit:main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I was expecting many more changes!
🚀
(edit: forgot to submit this before the merge..;)
@@ -278,6 +278,7 @@ class ProjectEventModelType(str, enum.Enum): | |||
release = "release" | |||
issue = "issue" | |||
koji_build_tag = "koji_build_tag" | |||
anitya_version = "anitya_version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first, it looked like a version of Anitya that doesn't make sense, but it might still be worth picking another name?
Maybe anitya_project_version
, or is it too verbose?
packit_service/service/api/utils.py
Outdated
anitya_project_id = anitya_project_name = anitya_package = project_url = ( | ||
repo_name | ||
) = repo_namespace = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is funnily long... Not sure if I like it.. but why not. I hope the meaning is clear for everyone.
I'm curious, what is Anitya? |
Fixes #2203
TODO:
RELEASE NOTES BEGIN
pull-from-upstream
is now supported also without specifyingupstream_project_url
in the configuration. For such cases, the upstream repository will not be detected and cloned during release syncing.RELEASE NOTES END