Require copr build job definition for tests #2012
Conversation
|
Build failed. ❌ pre-commit FAILURE in 9m 34s |
|
recheck |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 59s |
|
Shouldn't #1981 be fixed before this? It might not run any tests or at least create constant notifications otherwise |
|
@LecrisUT as you can see, that one is also in progress, and I will merge that one first, don't worry..and this one will also need to wait for the updates in affected PRs |
There was a problem hiding this comment.
I am wondering if we can't remove more. E.g. the required_for decorator.
Add pre-check for TestingFarmHandler that checks whether there is a copr build job definition in the config, if not, report it to user and do not run the tests. Related to packit#1775
Since now it is required to have a build job configuration for test configuration, this decorator is no longer needed.
lbarcziova
force-pushed
the
test-build-required
branch
from
e5e4aab to
36a2ebc
Compare
|
@lachmanfrantisek good point 👍 removed |
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 14s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 14s |
Add pre-check for TestingFarmHandler that checks whether there is a copr build job definition in the config, if not, report it to user and do not run the tests.
Related to #1775
Do not merge this before the configurations in affected repos are updated (or at least wait some time after PRs are opened)
RELEASE NOTES BEGIN
Packit will now additionally require for each test job requiring build a build job definition to be present in the Packit configuration file.
RELEASE NOTES END