Skip actor pre_check if actor not present #1733
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 56s |
|
But someone »does« the push or release, don't they? |
|
If I recall correctly, we previously did the check only for PRs since if a person commits or releases, he/she has also write access to the repo. |
| if not self.actor: | ||
| return False | ||
| logger.debug("Actor not set for this event, skipping the actor check.") | ||
| return True | ||
| return self._pre_check() |
There was a problem hiding this comment.
Aren't we checking also other non-actor conditions? (I went through the code really quickly and am not sure about the pre_check / _pre_check call chain...)
There was a problem hiding this comment.
e.g. project allowed for internal TF,..
There was a problem hiding this comment.
Thanks Laura for fixing this.
I did not realize I had changed the actor checker behaviour. You are right, before my changes it would have returned False only with a valid actor field.
Before my changes this code were called for every handler, but most of them just returned True, now it is called just for this two handlers Laura linked here.
This should make the behaviour the same as it was previously (before handler pre_checks refactoring https://github.com/packit/packit-service/blob/da94cc9b511843d73e9b94d20677f0b1d1426bf8/packit_service/worker/jobs.py#L422): if the actor is None, the actor pre_check will be skipped (e.g. pushes to branch, releases).
lbarcziova
force-pushed
the
actor-check-fix
branch
from
873bc25 to
b402b7c
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 05s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 59s |
Skip actor pre_check if actor not present
This should make the behaviour the same as it was previously (before handler pre_checks refactoring
packit-service/packit_service/worker/jobs.py
Line 422
in
da94cc9
if self.event.actor and not handler.check_if_actor_can_run_job_and_report(
): if the actor is None, the actor pre_check will be skipped (e.g. pushes to branch, releases).
RELEASE NOTES BEGIN
RELEASE NOTES END
Reviewed-by: Matej Focko <None>
Reviewed-by: None <None>
Reviewed-by: Laura Barcziová <None>
Reviewed-by: Maja Massarini <None>
This should make the behaviour the same as it was previously (before handler pre_checks refactoring
packit-service/packit_service/worker/jobs.py
Line 422 in da94cc9
RELEASE NOTES BEGIN
RELEASE NOTES END