Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retest-failed triggers also successful test runs #1886

Open
TomasTomecek opened this issue Feb 7, 2023 · 3 comments
Open

retest-failed triggers also successful test runs #1886

TomasTomecek opened this issue Feb 7, 2023 · 3 comments
Assignees
@majamassarini
Labels
area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@TomasTomecek
Copy link
Member

image

only 37 was failed, the comment triggered testing for 36 and rawhide as well

packit.yaml

specfile_path: ansible-bender.spec
actions:
  create-archive:
    - "python3 setup.py sdist --dist-dir ."
    - "sh -c 'echo ansible-bender-$(python3 setup.py --version).tar.gz'"
  get-current-version:
    - "python3 setup.py --version"
jobs:
- job: copr_build
  targets:
  - fedora-all
  trigger: pull_request
- job: tests
  trigger: pull_request
  targets:
  - fedora-all
- job: propose_downstream
  trigger: release
  dist_git_branches: [rawhide]
srpm_build_deps:
  - python3-pip # "python3 setup.py --version" needs it
  - python3-setuptools_scm
@TomasTomecek TomasTomecek moved this from new to backlog in Packit Kanban Board Feb 7, 2023
@TomasTomecek TomasTomecek added the kind/bug Something isn't working. label Feb 7, 2023
@Venefilyn
Copy link
Contributor

Just encountered this as well in oamg/convert2rhel#731

@TomasTomecek TomasTomecek added the discuss discuss To be discussed within a team (usually on the so-called Architecture meeting next Thursday) label Feb 7, 2023
@jpopelka jpopelka removed the discuss discuss To be discussed within a team (usually on the so-called Architecture meeting next Thursday) label Feb 16, 2023
@TomasTomecek TomasTomecek moved this from backlog to new in Packit Kanban Board Feb 16, 2023
@TomasTomecek TomasTomecek moved this from new to backlog in Packit Kanban Board Feb 16, 2023
@bocekm bocekm mentioned this issue Feb 20, 2023
Merged
7 tasks
@bocekm
Copy link

bocekm commented Feb 20, 2023

FYI, there's a known workaround - go to the Checks tab of the PR and re-run the failed jobs manually one by one.

@lbarcziova lbarcziova added complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. area/general Related to whole service, not a specific part/integration. gain/low This doesn't bring that much value to users. labels Apr 13, 2023
@lbarcziova
Copy link
Member

This especially doesn't work when using identifiers, as we filter only targets and utilise the *_targets_override and do not consider the identifiers at all (encountered in neoave/mrack#262)

@lachmanfrantisek lachmanfrantisek moved this from backlog to ready-to-refine in Packit Kanban Board Jul 13, 2023
@lachmanfrantisek lachmanfrantisek moved this from ready-to-refine to backlog in Packit Kanban Board Jul 13, 2023
@lbarcziova lbarcziova moved this from backlog to priority-backlog in Packit Kanban Board May 6, 2024
@pirat89 pirat89 mentioned this issue May 6, 2024
Merged
@majamassarini majamassarini self-assigned this Nov 4, 2024
@majamassarini majamassarini moved this from refined to in-progress in Packit Kanban Board Nov 4, 2024
@majamassarini majamassarini mentioned this issue Nov 26, 2024
Merged
softwarefactory-project-zuul bot added a commit that referenced this issue Nov 27, 2024
@softwarefactory-project-zuul
Consider identifiers when retriggering (#2658)
fc33a6f 
Consider identifiers when retriggering

Related to #1886

Reviewed-by: Laura Barcziová
Reviewed-by: Matej Focko
Reviewed-by: Maja Massarini
@majamassarini majamassarini mentioned this issue Nov 29, 2024
Merged
softwarefactory-project-zuul bot added a commit that referenced this issue Nov 29, 2024
@softwarefactory-project-zuul
Fix targets override identifier in check rerun and failed builds rela…
bc265c4 
…ted test retriggering (#2665)

Fix targets override identifier in check rerun and failed builds related test retriggering

Should fix #1519 #1886
RELEASE NOTES BEGIN
We have fixed /packit retest-failed which was retriggering also non failed tests.
RELEASE NOTES END

Reviewed-by: Laura Barcziová
@majamassarini majamassarini mentioned this issue Dec 3, 2024
Merged
softwarefactory-project-zuul bot added a commit that referenced this issue Dec 3, 2024
@softwarefactory-project-zuul
Check chroot in all targets (#2668)
d6b6a6e 
Check chroot in all targets

And not only in those that still need to be built.
Related to #1886

Reviewed-by: František Lachman <[email protected]>
@majamassarini majamassarini moved this from in-progress to done in Packit Kanban Board Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majamassarini majamassarini

Labels
area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Packit Kanban Board
Status: done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jpopelka @TomasTomecek @majamassarini @Venefilyn @bocekm @lbarcziova