Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating the markdown content for Github checks #1641

Closed
lbarcziova opened this issue Aug 31, 2022 · 0 comments · Fixed by #1688
Closed

Fix creating the markdown content for Github checks #1641

lbarcziova opened this issue Aug 31, 2022 · 0 comments · Fixed by #1688
Assignees
@majamassarini
Labels
area/user-experience Usability issue good-first-issue Good for newcomers.

Comments

@lbarcziova
Copy link
Member

If there are specified both URL and markdown content when reporting via Github checks, it results in a confusing table.
Example:
Snímka obrazovky z 2022-08-31 16-30-27

There are probably 2 problems:

  1. When creating the table in markdown content, the URL is always added in the row with Name/job Dashboard - in the example, it does not make sense since the URL does not point to the dashboard.
  2. The table should be followed by one more newline so that the additional markdown content is not part of the table.
@lbarcziova lbarcziova added area/user-experience Usability issue good-first-issue Good for newcomers. labels Aug 31, 2022
@lachmanfrantisek lachmanfrantisek moved this to 📋 Backlog 🔟 in Packit Kanban Board Sep 6, 2022
@lachmanfrantisek lachmanfrantisek moved this from backlog to refined in Packit Kanban Board Sep 6, 2022
@majamassarini majamassarini moved this from refined [10] to in-progress [10] in Packit Kanban Board Oct 7, 2022
@majamassarini majamassarini self-assigned this Oct 7, 2022
@majamassarini majamassarini mentioned this issue Oct 10, 2022
Merged
@majamassarini majamassarini moved this from in-progress [10] to in-review in Packit Kanban Board Oct 10, 2022
softwarefactory-project-zuul bot added a commit that referenced this issue Oct 11, 2022
@softwarefactory-project-zuul
Merge pull request #1688 from majamassarini/fix/packit-service/1641
911f4a2 
Improve table on github check page

Fixes #1641

RELEASE NOTES BEGIN
Fixed the markdown table format in the github checks page. The table was broken when the user's repo was not allowed to use Packit.
RELEASE NOTES END

Reviewed-by: Laura Barcziová <None>
Repository owner moved this from in-review to done in Packit Kanban Board Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majamassarini majamassarini

Labels
area/user-experience Usability issue good-first-issue Good for newcomers.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve table on github check page majamassarini/packit-service
2 participants
@majamassarini @lbarcziova