Deprecate CommitComment.comment in favour of body #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed. ❌ pre-commit FAILURE in 1m 53s |
added 2 commits
October 24, 2022 09:09
All other objects related to commenting use the word "body" for the attribute containing the content of the message. Make CommitComment consistent in this regard. Signed-off-by: František Nečas <[email protected]>
Signed-off-by: František Nečas <[email protected]>
lachmanfrantisek
approved these changes
Oct 24, 2022
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 54s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 47s |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to packit/packit-service#1716
RELEASE NOTES BEGIN
CommitComment.comment has been deprecated in favour of CommitComment.body to make the naming consistent across objects.
RELEASE NOTES END