Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

Run mypy without --no-strict-optional #55

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

jpopelka
Copy link
Member

@jpopelka jpopelka commented Apr 5, 2022

@softwarefactory-project-zuul

This comment was marked as outdated.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jpopelka
Copy link
Member Author

jpopelka commented Apr 5, 2022

STEP 3/7: RUN set -ex; mkdir -p ${HOME}/.config && echo "deployment: dev" > ${HOME}/.config/packit-service.yaml
/bin/sh: error while loading shared libraries: libc.so.6: cannot change memory protections

what the hack???

@jpopelka jpopelka requested a review from majamassarini April 6, 2022 08:53
@softwarefactory-project-zuul

This comment was marked as outdated.

jpopelka added a commit to jpopelka/hardly that referenced this pull request Apr 6, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

jpopelka added a commit to jpopelka/hardly that referenced this pull request Apr 6, 2022
@jpopelka jpopelka force-pushed the mypy-strict-optional branch from a4ef761 to 67dc188 Compare April 6, 2022 09:41
@softwarefactory-project-zuul

This comment was marked as outdated.

jpopelka added a commit to jpopelka/hardly that referenced this pull request Apr 6, 2022
@jpopelka jpopelka force-pushed the mypy-strict-optional branch from 67dc188 to 59401c4 Compare April 6, 2022 09:47
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jpopelka
Copy link
Member Author

jpopelka commented Apr 6, 2022

STEP 3/7: RUN set -ex; mkdir -p ${HOME}/.config && echo "deployment: dev" > ${HOME}/.config/packit-service.yaml
/bin/sh: error while loading shared libraries: libc.so.6: cannot change memory protections

From containers/podman#3234 & containers/podman#10817 it looks like a SELinux-related problem, but podman system reset doesn't help and I don't have permissions to disable SELinux.
I'll merge manually once approved and hope that it'll disappear as it appeared :-)

@jpopelka jpopelka force-pushed the mypy-strict-optional branch from 59401c4 to 92c0a3f Compare April 6, 2022 11:45
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

Copy link
Member

@majamassarini majamassarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played with it and locally I have no errors neither with the new pre-commit hook or the hardly tests.
I wish we were lucky!

But I think we will be not lucky. I opened the PR I am working on (even if it has just a no useful commit which is already inside this PR :-)) just to see if the zuul tests pass and they did not.

@jpopelka jpopelka merged commit 2d19339 into packit:main Apr 6, 2022
@jpopelka jpopelka deleted the mypy-strict-optional branch April 6, 2022 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants