Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace deploy playbook with role #627

Merged
merged 4 commits into from
Jan 2, 2025
Merged

fix: replace deploy playbook with role #627

merged 4 commits into from
Jan 2, 2025

Conversation

mfocko
Copy link
Member

@mfocko mfocko commented Dec 11, 2024 •
edited
Loading

TODO:

  • ansible-lint warnings for role
    • will be handled in a follow up
  • check if it's possible to move the roles/ out to the top-level to reduce the nesting
  • run tests on TF to make sure the changes are compatible

Supersedes #626

@mfocko mfocko self-assigned this Dec 11, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/11b22858264b411d9d82eb8886b31d99

✔️ pre-commit SUCCESS in 1m 24s

majamassarini
majamassarini approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@majamassarini majamassarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤞🏻🤞🏻🤞🏻

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/beb48202b1ed471aaadf5f1a3c296018

✔️ pre-commit SUCCESS in 1m 22s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c20567bbc381448da75b872ad224884f

❌ pre-commit FAILURE in 1m 24s

@mfocko mfocko force-pushed the chore/remove-deploy branch from 0946553 to da5b5cb Compare December 16, 2024 15:02
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d27adc16d94047088e7705abfd5fa4b4

❌ pre-commit FAILURE in 1m 22s

mfocko added 4 commits January 2, 2025 09:08
@mfocko
fix: replace deploy playbook with role
c1daab5 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
chore(ansible-lint): ignore role-prefix for deploy
38cb371 
Instead of copy-pasting the

    noqa: var-naming[no-role-prefix]

Ignore it globally for the whole file by using the ansible-lint ignore
file.

Signed-off-by: Matej Focko <[email protected]>
@mfocko
fix(roles): move roles out to the top-level
fdcf471 
Signed-off-by: Matej Focko <[email protected]>
@mfocko
tests: reduce verbosity of ansible-playbook
d911c47 
‹-vvv› outputs »a lot« of debugging information that can be useful when
debugging tmt or ansible-related issues specific to the Testing Farm
tests.

‹-vv› should provide enough details for day-to-day use.

If need be, this can be always reverted, but there's not much benefit in
having this on by default.

Signed-off-by: Matej Focko <[email protected]>
@mfocko mfocko force-pushed the chore/remove-deploy branch from da5b5cb to d911c47 Compare January 2, 2025 08:14
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/277d7a419c1d4697b1a1d16496eb0820

✔️ pre-commit SUCCESS in 1m 24s

@mfocko mfocko added mergeit When set, zuul wil gate and merge the PR. and removed mergeit When set, zuul wil gate and merge the PR. labels Jan 2, 2025
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5cfbfbfba8264e9a8072ad8b26f15191

✔️ pre-commit SUCCESS in 1m 26s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1896da5 into main Jan 2, 2025
4 checks passed
@mfocko mfocko deleted the chore/remove-deploy branch January 2, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

@majamassarini majamassarini majamassarini approved these changes

Assignees

@mfocko mfocko

Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
Packit Kanban Board
Status: done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfocko @majamassarini @lbarcziova