tokman: reduce the number of workers and resources in packit prod #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out, that having 2 workers running in parallel will lead to a race condition, and there will be times when there are multiple tokens requested for the same repo. Avoid this, by dropping the number of workers to 1. Adjust resources accordingly. Related to packit/tokman#53. Signed-off-by: Hunor Csomortáni <[email protected]>
|
This is already live on prod. |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 39s |
TomasTomecek
approved these changes
Feb 28, 2023
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 29s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out, that having 2 workers running in parallel will lead to a race condition, and there will be times when there are multiple tokens requested for the same repo. Avoid this, by dropping the number of workers to 1. Adjust resources accordingly.
Related to packit/tokman#53.