Retrieve all objects from list_devices endpoint #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickdevivo
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @hwnjng, @mmlb, and @patrickdevivo)
packet/Manager.py, line 76 at r1 (raw file):
def list_all_devices(self, project_id): all_devices = list()
maybe declare this down below right before it's used, like in between the while and the for loop? just cause it only becomes relevant later in the code. not a big deal
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hwnjng and @mmlb)
johnalotoski
pushed a commit
to input-output-hk/packet-python
that referenced
this pull request
Aug 12, 2019
* added support to retrieve all devices regardless of pagination * cleanup of Manager.py and added TODO test * fmt and lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR was taking in
per_pageparam to then list out all objects by hitting the api endpoints untilnextmetadata wasnull(more specifically, calling the apitotal % per_pagetimes). But, decided to just create a new function,list_all_devicesthat gets rid ofper_page. This was due to the fact that the end goal is to return everything anyway and thus the number of items per page becomes arbitrary.This change is