clear up ambiguity with RPM epochs #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamwillbar
requested changes
Nov 14, 2019
This is a real world example, part of fedora, but I'm not sure which distro version. I copied `fedora-25` from the example above it.
|
@iamwillbar I added the requested changes. Let me know if this works for you! |
|
@wgwoods do you have any thoughts on this before I go ahead and merge it? |
|
I want to agree with the notion here but - ugly though it is - I'm not sure whether you can consider epoch as optional separate from version? (More details in my comment in #69) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69