-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose apk #171
Propose apk #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the clarification of the namespace case sensitivity, it looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Aside from the case sensitivity point above, anything else blocking this being merged? I'm happy to finish things off as this looks like it's stalled. |
All mentioned issues has been fixed. I'm not sure why this hasn't been merged yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please resolve the conflicts so this can be merged. |
Reviewed-by: Ariadne Conill <[email protected]> Signed-off-by: Morten Linderud <[email protected]>
70b5c3c
@stevespringett rebased and should be all good now |
Reference: #3726 Reference: package-url/purl-spec#171 Reference: package-url/purl-spec#159 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Apparently the type was never called "alpine" but always "apk", see [1]. [1]: package-url/purl-spec#171 Signed-off-by: Sebastian Schuberth <[email protected]>
Apparently the type was never called "alpine" but always "apk", see [1]. [1]: package-url/purl-spec#171 Signed-off-by: Sebastian Schuberth <[email protected]>
Reviewed-by: Ariadne Conill [email protected]
Signed-off-by: Morten Linderud [email protected]