Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose apk #171

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Propose apk #171

merged 1 commit into from
Nov 10, 2022

Conversation

Foxboron
Copy link
Contributor

Reviewed-by: Ariadne Conill [email protected]
Signed-off-by: Morten Linderud [email protected]

Copy link
Member

@stevespringett stevespringett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the clarification of the namespace case sensitivity, it looks good to me.

PURL-TYPES.rst Outdated Show resolved Hide resolved
wagoodman
wagoodman previously approved these changes Jun 9, 2022
Copy link

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@garethr
Copy link

garethr commented Nov 7, 2022

Aside from the case sensitivity point above, anything else blocking this being merged? I'm happy to finish things off as this looks like it's stalled.

@Foxboron
Copy link
Contributor Author

Foxboron commented Nov 7, 2022

All mentioned issues has been fixed. I'm not sure why this hasn't been merged yet.

stevespringett
stevespringett previously approved these changes Nov 7, 2022
Copy link
Member

@stevespringett stevespringett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevespringett
Copy link
Member

Please resolve the conflicts so this can be merged.

Reviewed-by: Ariadne Conill <[email protected]>
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
Copy link
Contributor Author

Foxboron commented Nov 8, 2022

@stevespringett rebased and should be all good now

@stevespringett stevespringett merged commit dc13312 into package-url:master Nov 10, 2022
AyanSinhaMahapatra added a commit to aboutcode-org/scancode-toolkit that referenced this pull request May 8, 2024
sschuberth added a commit to oss-review-toolkit/ort that referenced this pull request Nov 22, 2024
Apparently the type was never called "alpine" but always "apk", see [1].

[1]: package-url/purl-spec#171

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit to oss-review-toolkit/ort that referenced this pull request Nov 22, 2024
Apparently the type was never called "alpine" but always "apk", see [1].

[1]: package-url/purl-spec#171

Signed-off-by: Sebastian Schuberth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants