Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitivity presentation comments #1197

Closed
kellijohnson-NOAA opened this issue Feb 7, 2025 · 1 comment
Closed

Sensitivity presentation comments #1197

kellijohnson-NOAA opened this issue Feb 7, 2025 · 1 comment

Comments

@kellijohnson-NOAA
Copy link
Collaborator

Thanks @chantelwetzel-noaa for making this presentation. I have a few nit-picky comments.

  1. slide 4--5, the title has "s.d." where elsewhere in the presentation and document we use "SD". we also might want to remind readers that the age-1 index is a "age-1 relative index"
  2. side 8, "Down-weight Fishery Comps" should be "Down-weight fishery comps"
  3. slide 10, can you move the legend up
  4. slide 11, it would be great if we could just change the y-axis label to say "Age 2+ biomass (Mt)" rather than need what figure is being shown in the title but I am not sure if that is possible
  5. 15--16 "mortality-at-age" should be "mortality at age" and same with maturity on slides 17--18
  6. I personally would cut slides 22--25 and just show 26. I do not think that we need the build up.
  7. slide 30, the ":" should be a comma. the commas at the end of each bulleted list should be semicolons
@chantelwetzel-noaa
Copy link
Contributor

I love nit-picky comments. I have made the changes requested for items 1-3, 5 (even though I am quite partial to dashes on at age items!), and 7. As for the other items:

  1. I am sure this could be done but it would require me to really dig into the code which would be time intensive for me since I am pretty unfamiliar with the plotting functions.
  2. I made a similar suggestion yesterday to cut down the presentation a bit more, but Aaron thought keeping all of them in was fine and it allows us to show clearly the impact of pulling two years of data off.
  3. I have switched the commas to semicolons but I will fight you over the colons. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants