-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop deprecated pkg_resources #287
Conversation
Oldlibs is failing, presumably there is a (Matplotlib?) version that doesn't like the Path objects and expects a string. Could convert to string but then it will stay that way forever: tempted to narrow down the problematic version and apply tweak in that case only. Then it is more likely to be cleaned up later... |
After a bit of binary search, Matplotlib styles support Path objects from version 3.2 (March 2020). It doesn't seem unreasonable to bump the minimum requirement to this. (Mantid is currently pinned to version 3.6) |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 28 28
Lines 3992 3992
Branches 803 803
=======================================
Hits 3824 3824
Misses 99 99
Partials 69 69
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo here.
Don't think there should be any concern about bumping.
I don't think so, I think we just use fairly standard Matplotlib methods which haven't changed between version 2 and 3. |
c5204f1
to
de87124
Compare
Great, thanks :-) Will merge when tests pass again. |
Having taken a look at the docs, the main difference is that you no longer have Python 2 support (which I don't think is an issue at this point) and unless you're mucking around in the backend, the interfaces are much the same for standard calls. |
This line was causing some deprecation warnings. I think this is the right way to modernise it?