Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated pkg_resources #287

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Drop deprecated pkg_resources #287

merged 3 commits into from
Sep 4, 2023

Conversation

ajjackson
Copy link
Collaborator

This line was causing some deprecation warnings. I think this is the right way to modernise it?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Test Results

       22 files  ±0         22 suites  ±0   55m 11s ⏱️ + 4m 20s
  1 049 tests ±0    1 043 ✔️ ±0    6 💤 ±0  0 ±0 
10 430 runs  ±0  10 367 ✔️ ±0  63 💤 ±0  0 ±0 

Results for commit de87124. ± Comparison against base commit 7042114.

♻️ This comment has been updated with latest results.

@ajjackson
Copy link
Collaborator Author

Oldlibs is failing, presumably there is a (Matplotlib?) version that doesn't like the Path objects and expects a string.

Could convert to string but then it will stay that way forever: tempted to narrow down the problematic version and apply tweak in that case only. Then it is more likely to be cleaned up later...

@ajjackson
Copy link
Collaborator Author

After a bit of binary search, Matplotlib styles support Path objects from version 3.2 (March 2020). It doesn't seem unreasonable to bump the minimum requirement to this.

(Mantid is currently pinned to version 3.6)

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Merging #287 (de87124) into master (7042114) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files          28       28           
  Lines        3992     3992           
  Branches      803      803           
=======================================
  Hits         3824     3824           
  Misses         99       99           
  Partials       69       69           
Files Changed Coverage Δ
euphonic/styles/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ajjackson
Copy link
Collaborator Author

@oerc0122 @mducle Is there any reason to be concerned about bumping the Matplotlib dependency a bit? It's nice to do things with Path objects where possible 😄

Copy link
Collaborator

@oerc0122 oerc0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo here.

Don't think there should be any concern about bumping.

CHANGELOG.rst Outdated Show resolved Hide resolved
@mducle
Copy link
Member

mducle commented Sep 4, 2023

I don't think so, I think we just use fairly standard Matplotlib methods which haven't changed between version 2 and 3.

@ajjackson
Copy link
Collaborator Author

Great, thanks :-) Will merge when tests pass again.

@oerc0122
Copy link
Collaborator

oerc0122 commented Sep 4, 2023

Having taken a look at the docs, the main difference is that you no longer have Python 2 support (which I don't think is an issue at this point) and unless you're mucking around in the backend, the interfaces are much the same for standard calls.

@ajjackson ajjackson merged commit 60ad0aa into master Sep 4, 2023
7 checks passed
@ajjackson ajjackson deleted the drop_pkg_resources branch September 4, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants