-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.7 support, bump Scipy, Pint, h5py requirements #284
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 28 28
Lines 3958 3958
Branches 798 798
=======================================
Hits 3791 3791
Misses 98 98
Partials 69 69 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Linux builds are fine with 3.8 but strange things are happening on Windows and it would be good to know how this affects them.
Strange things happening on Windows seem to be resolved if we stay on 3.7 as the host version for tox. That's a bit silly but solves the immediate issue for minimal effort. Playing more with tox and github actìons may have to wait until next year! |
Thanks for speedy review! I'll just call the CI manually to make sure 3.9 and 3.10 are happy before merging. https://github.com/pace-neutrons/Euphonic/actions/runs/6047171355 |
Tests look fine 🚀 |
Closes #278
This PR should focus on mechanics of version bump; subsequent PRs can introduce new goodies.