Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.7 support, bump Scipy, Pint, h5py requirements #284

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

ajjackson
Copy link
Collaborator

@ajjackson ajjackson commented Aug 31, 2023

Closes #278

This PR should focus on mechanics of version bump; subsequent PRs can introduce new goodies.

@ajjackson ajjackson added this to the v1.3.0 milestone Aug 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #284 (a0ec26e) into master (7f58868) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files          28       28           
  Lines        3958     3958           
  Branches      798      798           
=======================================
  Hits         3791     3791           
  Misses         98       98           
  Partials       69       69           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

Test Results

       28 files  +       9         28 suites  +9   1h 33m 18s ⏱️ + 59m 36s
  1 040 tests ±       0    1 034 ✔️ ±       0    6 💤 ±  0  0 ±0 
16 544 runs  +9 306  16 445 ✔️ +9 252  99 💤 +54  0 ±0 

Results for commit a0ec26e. ± Comparison against base commit 7f58868.

♻️ This comment has been updated with latest results.

Linux builds are fine with 3.8 but strange things are happening on
Windows and it would be good to know how this affects them.
@ajjackson
Copy link
Collaborator Author

Strange things happening on Windows seem to be resolved if we stay on 3.7 as the host version for tox. That's a bit silly but solves the immediate issue for minimal effort. Playing more with tox and github actìons may have to wait until next year!

@ajjackson ajjackson marked this pull request as ready for review August 31, 2023 17:11
@ajjackson ajjackson requested a review from oerc0122 August 31, 2023 17:13
@ajjackson
Copy link
Collaborator Author

ajjackson commented Sep 1, 2023

Thanks for speedy review! I'll just call the CI manually to make sure 3.9 and 3.10 are happy before merging.

https://github.com/pace-neutrons/Euphonic/actions/runs/6047171355

@ajjackson
Copy link
Collaborator Author

Tests look fine 🚀

@ajjackson ajjackson merged commit 7823336 into master Sep 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Python requirement to 3.8
3 participants