Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving onClick event to React node #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Trinitonn
Copy link

@Trinitonn Trinitonn commented Jan 20, 2024

When you supply a React node, I'd like to move the onClick event to the React node instead of the surrounding span element.

In my case I wanted to center a small button below the text in the center of the parent container that holds the text. Moving the onClick event makes sure you need to click the button (and not the span element which is 100% width of the parent container).

Before this change you could click anywhere to the left or right of the button instead of straight on it.

@Trinitonn Trinitonn closed this Jan 20, 2024
@Trinitonn Trinitonn reopened this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant