-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling of new DataHoverEvent #77
Conversation
New panel types in Grafana may emit DataHoverEvents instead of LegacyGraphHoverEvents. Fixes pR0Ps#67
Some graph types may emit events where there is no sensible value for x position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build your adoptions into on our local grafana plugins directory, they are working perfectly :)! Many thanks!!
Looks good to me, thanks for contributing! (and thanks to @Bart-1992 for confirming it works) |
Cool. Thx. Don't you have to bump a new release or how is this received by Grafana Labs for the Plugin? |
Please release it as new version to grafana too. Edit |
@umbm I managed to get it working on our linux machine with following procedure: First off all you need to make sure you can install 'unsigned' plugins into your grafana application:
Plugins section needs to look like this ( if not available in grafana.ini, just add this section ).
Remove the old Pr0ps plugin ( using Grafana GUI ) or manually using command line
After this the plugin should be working. |
Thx but i prefer signed plugins for prod servers. Would be nice to have it within grafana. |
Sorry all, I'll push an update hopefully later today. I've had issues with my setup to test this locally which I would normally like to do before pushing a release. In this case though it seems like the released version is just broken and @Bart-1992 reports that the current HEAD is not so I'll just go for it. |
No worries, good to hear, that's the way, thank you for your work! |
New panel types in Grafana may emit DataHoverEvents instead of LegacyGraphHoverEvents.
Fixes #67