Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Typography #377

Merged
merged 6 commits into from
Aug 18, 2022
Merged

Improve Typography #377

merged 6 commits into from
Aug 18, 2022

Conversation

tushar5526
Copy link
Member

@tushar5526 tushar5526 commented Aug 15, 2022 •
edited
Loading

Related to #371
This PR covers

  • text_width
  • text_leading
  • text_align
  • Added support for multiline pythonic strings and multiline strings

@tushar5526
Copy link
Member Author

tushar5526 commented Aug 15, 2022 •
edited
Loading

@ziyaointl I bumped the numpy in this PR, because the tests were failing. Should I make a separate PR for that and then rebase this on the updated master ?

ziyaointl
ziyaointl reviewed Aug 16, 2022
View reviewed changes
Copy link
Member

@ziyaointl ziyaointl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Yeah I do think making a separate PR for numpy then rebasing is the best practice.

p5/visualTests/sanityTests/2DSanityTests/test5.py Outdated Show resolved Hide resolved
p5/visualTests/sanityTests/tmp_test37.py Outdated Show resolved Hide resolved
p5/sketch/Skia2DRenderer/renderer2d.py Outdated Show resolved Hide resolved
@tushar5526
Implemented text_align and updated tests
3b380b4
@tushar5526
Implemented
4e232b5 
- text_leading
- text_width
- Support multiline pythonic strings for skia
@tushar5526
Fix typography test
bd2ad26
@tushar5526
- Updated the text rendering logic to be O(n)
df78a43 
- Remove tmp test file
- Removed debug statement
@tushar5526
Copy link
Member Author

tushar5526 commented Aug 16, 2022 •
edited
Loading

Implementing text_wrap was fun :p

skia_text.mp4

@tushar5526 tushar5526 requested a review from ziyaointl August 18, 2022 04:31
@ziyaointl ziyaointl merged commit 9d56400 into master Aug 18, 2022
@ziyaointl ziyaointl deleted the typography branch August 18, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziyaointl ziyaointl ziyaointl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushar5526 @ziyaointl