-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch statement not correctly translated when default case is not present #2986
Conversation
Why isn't the default case present? Previous passes should have inserted one. |
Currently, in "SwitchAddDefault" pass in frontend, default entry in switch is only inserted if the expression is based on "Action Type" or "action_run". There is no implementation for adding default entry for generic switch statement with integer or enumerated type expression. So, as processing for switch statement with integer or enumerated type expression is done in "EliminateSwitch" pass in midend, implementation for adding default entry has been added here if it is not present |
fd53229
to
71063aa
Compare
I have already approved this, but you still have conflicts that you need to rebase. |
84c3938
to
dea163f
Compare
I have resolved the conflict. Kindly approve and merge |
If the extra spaces appeared after you rebased there is a bug somewhere else in the compiler that we should track. |
dea163f
to
f9b72a5
Compare
d822214
to
ae63850
Compare
I have raised a new PR for the same and closing this out due to other irrelevant files getting updated while resolving conflict and rebasing. Kindly check and approve for the same |
…esent