-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default behavior of IPOnDemand
domain strategy
#329
Conversation
tunnel/router/client.go
IPOnDemand
domain strategy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the default behavior of IPOnDemand
, but I think it's more appropriate than it used to be.
For users don't know what's going on: The concept of domain strategy( In Trojan-Go(<= v0.10.0) instead, no priority between geoip rules and geosite rules. In other words, all geoip rules or all geosite rules are treated as a whole, therefore the major difference between After this PR, the new default behavior will be:
The resolved IP will just be used to pick a route policy(block, bypass or proxy), the destination address(domain) will not be changed. |
Hi everyone,
I noticed that the previous domain strategy will nullify domain rules when ip_on_demand is used.
Therefore here is my proposal on this section that:
I am looking forward to your ideas and feedback.
Regards,
Chinese White Dolphin