Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: error when upload in cancelled and limit max percentage #34

Merged
merged 2 commits into from
Oct 22, 2022
Merged

Conversation

zluipaiva
Copy link
Contributor

@zluipaiva zluipaiva commented Oct 21, 2022

Related Issue (if any)

Closes: #33

Describe the add-ons or changes you've made

Modified the upload functions to not execute when files.length is 0.
Also a small fix on the percentage loader to always be smaller than 100% (it used to break for very small files, e.g. an empty folder)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The same steps mentioned on #33

  1. Click on "Upload" button
  2. Select a file and confirm upload
  3. Click on "Upload" again
  4. Cancel the file upload

Checklist:

  • My code follows the "contribution guidelines" of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.

@akhileshthite akhileshthite self-requested a review October 22, 2022 13:58
Copy link
Member

@akhileshthite akhileshthite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.
You'll see your changes in few days once it's updated on the chrome.

@akhileshthite akhileshthite merged commit 44dbcc6 into p2plabsxyz:main Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on upload cancel
2 participants