Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7 Upgrade #552

Merged
merged 7 commits into from
Aug 17, 2024
Merged

Rails 7 Upgrade #552

merged 7 commits into from
Aug 17, 2024

Conversation

BenjaminSchaaf
Copy link
Collaborator

I've upgraded citadel to Rails 7.1, allowing it to run on supported ruby 3.1. This kills most of the pain-points setting up a development environment and deploying citadel.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 95.52239% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.21%. Comparing base (3b88d51) to head (cfe100d).
Report is 10 commits behind head on master.

Files Patch % Lines
app/models/league.rb 66.66% 1 Missing ⚠️
app/services/leagues/matches/generation_service.rb 0.00% 1 Missing ⚠️
...ces/leagues/matches/pick_bans/deferring_service.rb 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   95.16%   95.21%   +0.04%     
==========================================
  Files         193      193              
  Lines        4533     4532       -1     
==========================================
+ Hits         4314     4315       +1     
+ Misses        219      217       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenjaminSchaaf
Copy link
Collaborator Author

Since there's been no objections to this I'll be merging it.

@BenjaminSchaaf BenjaminSchaaf merged commit 5025e41 into master Aug 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant