Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize color palette with .glsrc file #25

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

gozeloglu
Copy link
Contributor

  • readGLSRCFile function added. This function reads and overrides the vars.
  • Test data added.
  • Tests added.
  • README updated.

Signed-off-by: Gökhan Özeloğlu [email protected]

Summary

Fixes #16

I added a new feature for customizing the color palette by .glsrc file.

Impact

  • New feature (backward compatible change which adds functionality)

Testing

Tests are using testdata under the gui directory. There is no special instruction to run the tests.

Test Configuration:

  • Go version: go1.18.2 darwin/amd64
  • Hardware: MBP 2019 16 GB RAM 2,3 GHz 8-Core Intel Core i9 DDR4
  • Operating system: macOS Monterey

* `readGLSRCFile` function added. This function reads and overrides the vars.

* Testdata added.

* Tests added.

* README updated.

Signed-off-by: Gökhan Özeloğlu <[email protected]>
Copy link
Owner

@ozansz ozansz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution! also the PR is well-documented

gui/constants.go Outdated Show resolved Hide resolved
@ozansz ozansz merged commit 1a73423 into ozansz:main Oct 11, 2022
@gozeloglu gozeloglu deleted the add-customize-glsrc branch October 11, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TUI color palette should be customizable through .glsrc
2 participants