Productsの実装 #126
Merged
Productsの実装 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
↑違った |
|
#128 直してみました |
mii288
reviewed
Apr 14, 2021
styles/custom.css
Outdated
| Products section | ||
| ==================================================================*/ | ||
|
|
||
| .products-tags:not(:last-child) { |
There was a problem hiding this comment.
poem: 書き手の好みですが、 :not 使うと詳細度高くなるので、隣接セレクタでかいても良いかもしれないですね。
（このデザインいつまで使うのかという問題もありますがｗ）
.products-tags + .products-tags {
margin-left: 4px;
}There was a problem hiding this comment.
未だに詳細度の優先度わかってないからなるほどなとなった
高すぎると上書きづらいし良さそう
Productsの画像のリサイズ（CIのエラー修正）
#126 (comment) 詳細度高いと上書きづらいし良さそうに思える
mii288
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #98