Allow page objects to skip the definition of a container #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demanding page objects to define a container is a weird requirement, that is likely to just generate development overhead without any practical benefit.
khamusa
force-pushed
the
feature/pages-can-omit-container
branch
from
484db53 to
3e0ab31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demanding page objects to define a container is a weird requirement, that is likely to just generate development overhead without any practical benefit.
This PR makes it optional to define a container for Page objects (not for Section objects though). If a container test id is provided, it will be used, otherwise the document body will be used as container.