fix(cache): can not mkdir multilevel folder #45
Conversation
Closing tab is not very determinictic, closing buffers should hopefully always work
You can now open a global scratch buffer available in any instance, or a named buffer which is also available in any instance
* Update README.md Replace unmaintained rest.nvim with kulala.nvim. * Update README.md Re-naming + re-adding rest.nvim. Similar plugins are in alphabetical order.
custom buffers can now be opened either scoped globally, or scoped to cwd The old method has been deprecated, and you should now use the explicit custom global method instead. See issue #20
Removed logic around window id, simplified by always replacing the command buffer
Collection names are now exposed through the API. ":CurlOpen collection scoped" now autocompletes on collection names New API and usercommand methods runs a picker where you can select collections
Result buffer now opens at the point of origin, and not to the right of the split when the request finishes. This will probably only be relevant when debugging. See readme for tips on improving nvim-dap issues.
…it for execution instead this is more inline with other plugins
lua/curl/cache.lua
Outdated
| @@ -21,7 +22,10 @@ local curl_cache_dir = function(custom_dir) | |||
| cache_dir = cache_dir / custom_dir ---@type Path | |||
| end | |||
|
|
|||
| cache_dir:mkdir({ parents = true, exists_ok = true }) | |||
| if vim.fn.mkdir(cache_dir:absolute(), "p") ~= 1 then | |||
| notify.error("create directory error: " .. cache_dir:absolute()) | |||
There was a problem hiding this comment.
This message goes to the user, we should perhaps formalize it a little bit:
"Error creating collection: could not create directory " .. cache_dir:absolute()
|
@iamxiaojianzheng Didn't realize that it would rewrite so much, you might need to recreate this PR :P |
I don't know how you modify it, I just modify the information of a commit individually through lazygit. Other commits are not affected. |
|
@iamxiaojianzheng I used this: https://github.com/newren/git-filter-repo I think is rewrites the history completely, so that the email is not in the history at all. Sorry for the complications, but maybe you need to etither sync your branch with main, or recreate your fork. |
This works better for global changes, but lazygit is the easiest solution I've found so far if you're only changing partial commits. The features are really impressive. |
about this #44