iOS two finger fix #12
Conversation
…ix the zoom issue in ios
|
this is supposed to fix issue #10 |
|
Thanks for the PR, @jaisont07! I just tested it on iOS 17.5 (via the ExampleBrowser in the Basically two-finger zooming seems to work, but it does not always work perfectly and sometimes seems to behave strangely. E.g. the plot jumps occasionally while doing a two-finger pinch gesture (or when putting down the second finger while the first one is already touching). This behavior seems similar to what I saw on my branch mentioned at #10 (comment). @jaisont07 Can you reproduce these quirks, and do you have an idea what causes them? @RobertStefancic Could you maybe also try the branch, and tell us how well it works for you? Does your implementation at #10 (comment) work any better, or does it suffer from the same problems? The GHA builds actually ran through fine without any problems, which is good. I'll try to look through the code changes soon. |
| { | ||
| long id = ((IntPtr)touch.Handle).ToInt64(); | ||
| CheckForBoundaryHop(touch); | ||
| if (idToTouchDictionary[id] != null) | ||
| { | ||
| FireEvent(idToTouchDictionary[id], id, TouchActionType.Moved, touch, true); | ||
| //FireEvent with all the points within the touch event | ||
| FireEvent(idToTouchDictionary[id], id, TouchActionType.Moved, touch, true, uitouches.IndexOf(touch) == uitouches.Count - 1); |
There was a problem hiding this comment.
I guess the same multi-point handling that you're using here should also be applied to the FireEvent calls in TouchesBegan and TouchesEnded ?
|
@jaisont07 @RobertStefancic Ping! Is there still interest in this feature? If yes, could you reply to my comments, so that we can move forward with this? I think it would be great to add proper zoom support for iOS ... |
@janusw Yes this is required. But I am also able to reproduce the not so smooth zoom issue with all these fixes. Would be great if we could find a solution to this.. |
|
@janusw @jaisont07 I created a pull-request as well here: #15 Edit: First thing I noticed for the snappy behavior is that the touch events where coming rarely (which is different from Android, where they come often), hence I added the ShouldRecognizeSimultaneously => true. |
|
I'm closing this PR in favor of #15 (which was just merged). |
Added the uitouched to a list and fireevent with the points list to fix the zoom issue in ios