Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit bartlett/sarif-php-sdk dependency constraint to versions 1.x #3729

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

llaville
Copy link
Collaborator

@llaville llaville commented Jul 1, 2024

Proposed Changes

This will avoid issue when major version 2.0 of bartlett/sarif-php-sdk will be released, because converters were removed from this package.
Will be include in next generation with package/repo https://github.com/llaville/sarif-php-converters (soon available)

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Copy link
Contributor

github-actions bot commented Jul 1, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ API spectral 2 0 2.46s
✅ BASH bash-exec 5 0 0.01s
✅ BASH shellcheck 5 0 0.13s
✅ BASH shfmt 5 0 0 0.6s
✅ COPYPASTE jscpd yes no 3.95s
✅ DOCKERFILE hadolint 129 0 16.64s
✅ JSON jsonlint 18 0 0.21s
✅ JSON v8r 20 0 30.48s
⚠️ MARKDOWN markdownlint 266 0 272 36.24s
✅ MARKDOWN markdown-table-formatter 266 0 0 139.74s
✅ OPENAPI spectral 2 0 3.04s
⚠️ PYTHON bandit 212 64 2.92s
✅ PYTHON black 212 0 0 5.64s
✅ PYTHON flake8 212 0 2.11s
✅ PYTHON isort 212 0 0 1.25s
✅ PYTHON mypy 212 0 19.03s
✅ PYTHON pylint 212 0 19.66s
✅ PYTHON ruff 212 0 0 0.66s
✅ REPOSITORY checkov yes no 42.12s
✅ REPOSITORY git_diff yes no 0.57s
⚠️ REPOSITORY grype yes 1 18.85s
✅ REPOSITORY secretlint yes no 12.49s
✅ REPOSITORY trivy yes no 20.42s
✅ REPOSITORY trivy-sbom yes no 8.05s
⚠️ REPOSITORY trufflehog yes 1 11.83s
✅ SPELL cspell 694 0 26.44s
⚠️ SPELL lychee 347 5 29.22s
✅ XML xmllint 3 0 0 0.59s
✅ YAML prettier 161 0 0 5.5s
✅ YAML v8r 102 0 185.1s
✅ YAML yamllint 162 0 2.33s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator

echoix commented Jul 1, 2024

/build

Command run output
Build command workflow started.
Installing dependencies
Running script ./build.sh
Build command workflow completed updating files.

@echoix echoix enabled auto-merge (squash) July 1, 2024 11:05
@echoix echoix merged commit 78e26c6 into main Jul 1, 2024
124 checks passed
@echoix echoix deleted the fix/sarif-php-sdk-constraint branch July 1, 2024 11:09
@llaville
Copy link
Collaborator Author

llaville commented Jul 1, 2024

Thanks @echoix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants