Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ghcr.io/terraform-linters/tflint docker tag to v0.52.0 #3712

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 29, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
ghcr.io/terraform-linters/tflint minor 0.51.1 -> 0.52.0
ghcr.io/terraform-linters/tflint stage minor v0.51.1 -> v0.52.0

Release Notes

terraform-linters/tflint (ghcr.io/terraform-linters/tflint)

v0.52.0

Compare Source

v0.51.2

Compare Source

What's Changed

Full Changelog: terraform-linters/tflint@v0.51.1...v0.51.2


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jun 29, 2024
Copy link
Contributor

github-actions bot commented Jun 29, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ API spectral 2 0 3.12s
✅ BASH bash-exec 5 0 0.02s
✅ BASH shellcheck 5 0 0.16s
✅ BASH shfmt 5 0 0 0.56s
✅ COPYPASTE jscpd yes no 5.02s
✅ DOCKERFILE hadolint 129 0 13.75s
✅ JSON jsonlint 18 0 0.2s
✅ JSON v8r 20 0 29.41s
⚠️ MARKDOWN markdownlint 266 0 272 37.93s
✅ MARKDOWN markdown-table-formatter 266 0 0 133.24s
✅ OPENAPI spectral 2 0 2.98s
⚠️ PYTHON bandit 212 64 3.56s
✅ PYTHON black 212 0 0 5.76s
✅ PYTHON flake8 212 0 2.33s
✅ PYTHON isort 212 0 0 1.64s
✅ PYTHON mypy 212 0 18.68s
✅ PYTHON pylint 212 0 17.13s
✅ PYTHON ruff 212 0 0 0.98s
✅ REPOSITORY checkov yes no 42.6s
✅ REPOSITORY git_diff yes no 0.6s
⚠️ REPOSITORY grype yes 1 23.05s
✅ REPOSITORY secretlint yes no 12.96s
✅ REPOSITORY trivy yes no 22.4s
✅ REPOSITORY trivy-sbom yes no 1.38s
⚠️ REPOSITORY trufflehog yes 1 12.88s
✅ SPELL cspell 694 0 27.49s
⚠️ SPELL lychee 347 5 10.76s
✅ XML xmllint 3 0 0 0.57s
✅ YAML prettier 161 0 0 5.63s
✅ YAML v8r 102 0 97.58s
✅ YAML yamllint 162 0 2.19s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator

echoix commented Jun 29, 2024

Why is the help command for terraform-fmt fail now? The changes don't seem to contain a change that could affect this

@nvuillam
Copy link
Member

@echoix according to the errors, it's linter-helps.json that is unparseable
strange

@echoix
Copy link
Collaborator

echoix commented Jun 29, 2024

Something wrongly escaped?

@echoix
Copy link
Collaborator

echoix commented Jun 29, 2024

I'll make it retry

@echoix
Copy link
Collaborator

echoix commented Jun 29, 2024

Its not the same failure:
https://github.com/oxsecurity/megalinter/actions/runs/9723818407/job/26839360161#step:11:3158
is
FAILED megalinter/tests/test_megalinter/linters/terraform_terraform_fmt_test.py::terraform_terraform_fmt_test::test_get_linter_help

and https://github.com/oxsecurity/megalinter/actions/runs/9725560216/job/26843028822?pr=3712#step:11:3822
is
FAILED megalinter/tests/test_megalinter/linters/typescript_standard_test.py::typescript_standard_test::test_format_fix

What exactly does the tests do just to make sure? And what are the pytest fixtures used (and their scopes)? Do they mount to the same folders and some tests try to change the same files with more than one Megalinter docker running at the same time? Something like it is not really well isolated at the files mounted level?

@nvuillam
Copy link
Member

get_linter_help just checks that we succeed to call the help of the linter cli

test_format_fix checks that the linter update files to format/fix
the check is done using git diff, so sometimes it can randomly fail because of parallel testing

@renovate renovate bot force-pushed the renovate/ghcr.io-terraform-linters-tflint-0.x branch from a36a649 to f516cb6 Compare July 6, 2024 16:26
@renovate renovate bot changed the title chore(deps): update ghcr.io/terraform-linters/tflint docker tag to v0.51.2 chore(deps): update ghcr.io/terraform-linters/tflint docker tag to v0.52.0 Jul 6, 2024
@nvuillam nvuillam merged commit 1b22656 into main Jul 6, 2024
128 checks passed
@nvuillam nvuillam deleted the renovate/ghcr.io-terraform-linters-tflint-0.x branch July 6, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants