enhancement: TFLint - fix deprecated argument in ".tflint.hcl" and other improvements #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyE123
requested review from
nvuillam,
echoix,
bdovaz and
Kurt-von-Laven
as code owners
echoix
approved these changes
Jun 24, 2024
|
Looks great! |
|
.... and @TommyE123 strikes again ! :) Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TFLint fix deprecated argument in ".tflint.hcl"
Fixes #3618
Context:
@mg-alanjones kindly highlighted a warning appearing when running
TFLINT.WARNING: "module" attribute in /action/lib/.automation/.tflint.hcl is deprecated. Use "call_module_type" instead.I’ve fixed this along with some improvements.
Changes:
In the megalinter default template:
• Updated the commented url https://github.com/terraform-linters/tflint/blob/master/docs/user-guide/config.md.
• Switched from
module = falsetocall_module_type = "local".• Added more plugins so it now supports
AWS,AZUREARMandGOOGLE.Other changes:
• Added more tests to support the 3 languages.
• Documentation to suggest using a config refined to a language.
Testing:
AZURE PIPELINE – Terraform project using megalinter default template with forced linting error.
Before:
After:
Note appears in tflint page
If there are any issues or concerns, please let me know, and I will address them promptly.
Thank you for reviewing this PR and I look forward to your feedback.
Tom