Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort schema enums #3595

Merged
merged 11 commits into from
May 31, 2024
Merged

Sort schema enums #3595

merged 11 commits into from
May 31, 2024

Conversation

echoix
Copy link
Collaborator

@echoix echoix commented May 29, 2024

Fixes #

Proposed Changes

  1. …
  2. …
  3. …

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix
Copy link
Collaborator Author

echoix commented May 29, 2024

Needs to apply black

@echoix
Copy link
Collaborator Author

echoix commented May 29, 2024 •
edited by github-actions bot
Loading

/build

Command run output
Build command workflow started.
Installing dependencies
Running script ./build.sh

@github-actions GitHub Actions
Copy link
Contributor

Build command workflow failed.

@echoix
Copy link
Collaborator Author

echoix commented May 29, 2024

Oops, I’ll rebase to something without my other changes

@echoix echoix force-pushed the sort-schema-enums branch from 630edc6 to 92acf50 Compare May 30, 2024 01:11
@echoix echoix force-pushed the sort-schema-enums branch from 92acf50 to e1b612a Compare May 30, 2024 01:26
@echoix
Copy link
Collaborator Author

echoix commented May 30, 2024

Done and ready, all set

@echoix echoix mentioned this pull request May 30, 2024
Merged
nvuillam
nvuillam approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

@nvuillam nvuillam merged commit f4dbe62 into oxsecurity:main May 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvuillam nvuillam nvuillam approved these changes

@bdovaz bdovaz Awaiting requested review from bdovaz bdovaz is a code owner

@Kurt-von-Laven Kurt-von-Laven Awaiting requested review from Kurt-von-Laven Kurt-von-Laven is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echoix @nvuillam