-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dotnet linters to .NET 8 #3182
Conversation
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ BASH | bash-exec | 5 | 0 | 0.02s | |
✅ BASH | shellcheck | 5 | 0 | 0.13s | |
✅ BASH | shfmt | 5 | 0 | 0 | 0.59s |
✅ COPYPASTE | jscpd | yes | no | 4.34s | |
✅ DOCKERFILE | hadolint | 127 | 0 | 16.29s | |
✅ JSON | eslint-plugin-jsonc | 23 | 0 | 0 | 4.7s |
✅ JSON | jsonlint | 21 | 0 | 0.34s | |
✅ JSON | v8r | 23 | 0 | 26.72s | |
✅ MAKEFILE | checkmake | 1 | 0 | 0.01s | |
markdownlint | 261 | 0 | 265 | 33.43s | |
✅ MARKDOWN | markdown-link-check | 261 | 0 | 10.98s | |
✅ MARKDOWN | markdown-table-formatter | 261 | 0 | 0 | 142.18s |
✅ OPENAPI | spectral | 1 | 0 | 1.49s | |
bandit | 208 | 64 | 3.52s | ||
✅ PYTHON | black | 208 | 0 | 0 | 6.04s |
✅ PYTHON | flake8 | 208 | 0 | 2.44s | |
✅ PYTHON | isort | 208 | 0 | 0 | 1.37s |
✅ PYTHON | mypy | 208 | 0 | 16.32s | |
✅ PYTHON | pylint | 208 | 0 | 17.07s | |
pyright | 208 | 352 | 27.85s | ||
✅ PYTHON | ruff | 208 | 0 | 0 | 0.67s |
✅ REPOSITORY | checkov | yes | no | 43.31s | |
✅ REPOSITORY | git_diff | yes | no | 0.57s | |
grype | yes | 1 | 25.26s | ||
✅ REPOSITORY | secretlint | yes | no | 18.55s | |
✅ REPOSITORY | trivy | yes | no | 26.41s | |
✅ REPOSITORY | trivy-sbom | yes | no | 9.65s | |
trufflehog | yes | 1 | 11.83s | ||
✅ SPELL | cspell | 683 | 0 | 29.31s | |
✅ SPELL | lychee | 341 | 0 | 8.24s | |
✅ XML | xmllint | 3 | 0 | 0 | 0.55s |
✅ YAML | prettier | 160 | 0 | 0 | 6.69s |
✅ YAML | v8r | 102 | 0 | 180.7s | |
✅ YAML | yamllint | 161 | 0 | 2.38s |
See detailed report in MegaLinter reports
Fails with:
This page shows this warning, we will wait until it "fixes itself":
https://learn.microsoft.com/en-us/dotnet/core/install/linux-alpine |
Indeed, I don't see any dotnet8 packages in the alpine packages, even on edge. I thought I had seen them, but maybe it was only the Ms docs. I think the note was for when the docs was released, since I see some that had the build date on the 16th |
At least if we have dotnet 7 in a first release it's already better |
I already predicted that something might happen and that's why I didn't mix PRs 🤣 |
Let's quitely wait .net8 to be in alpine packages, I'm so glad we don't need to install it the messy way anymore ^^ |
It is still the same, I have reported it to see if I call attention and they can prioritize it: dotnet/sdk#37790 |
I forgot to mention it, but from what they say, until alpine 3.20 they will not include it: dotnet/sdk#37790 (comment) |
Is there a way to install it from the edge version meanwhile ? |
@nvuillam at least I can't answer you, I have no experience with alpine and its packages.... But in case we can it would be the way to unblock this problem now and in the future because it can happen again with .NET 9... |
Doing a quick search it looks like it is: https://stackoverflow.com/a/52903112 |
@bdovaz if you want to try something like |
@nvuillam done! |
@nvuillam ready! |
I think it's ok, since the tests pass. How breaking of a change is this to projects using Megalinter (estimated)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing @bdovaz :)
No description provided.