Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkmake to lint Makefile #1644

Merged
merged 8 commits into from
Jul 24, 2022
Merged

Add checkmake to lint Makefile #1644

merged 8 commits into from
Jul 24, 2022

Conversation

nvuillam
Copy link
Member

Fixes #1627

@nvuillam
Copy link
Member Author

MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.03s
✅ BASH shellcheck 7 0 0.22s
✅ BASH shfmt 7 0 0 0.06s
✅ COPYPASTE jscpd yes no 1.8s
✅ DOCKERFILE hadolint 102 0 17.78s
✅ JSON eslint-plugin-jsonc 20 0 0 1.85s
✅ JSON jsonlint 18 0 4.21s
✅ JSON v8r 20 0 9.92s
⚠️ MARKDOWN markdownlint 277 0 4 3.79s
✅ MARKDOWN markdown-link-check 277 0 5.02s
✅ MARKDOWN markdown-table-formatter 277 0 0 5.83s
✅ OPENAPI spectral 1 0 0.81s
⚠️ PYTHON bandit 163 50 1.88s
✅ PYTHON black 163 0 0 2.84s
✅ PYTHON flake8 163 0 2.33s
✅ PYTHON isort 163 0 0 0.34s
✅ PYTHON mypy 163 0 92.52s
✅ PYTHON pylint 163 0 14.9s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 10.27s
⚠️ REPOSITORY semgrep yes 182 51.13s
✅ REPOSITORY trivy yes no 23.38s
❌ SPELL cspell 866 14 21.0s
✅ SPELL misspell 700 0 0 0.35s
✅ XML xmllint 3 0 0.01s
✅ YAML prettier 79 1 0 2.67s
✅ YAML v8r 22 0 23.8s
✅ YAML yamllint 80 0 1.07s

See errors details in artifact MegaLinter reports on CI Job page

@nvuillam
Copy link
Member Author

nvuillam commented Jul 24, 2022

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.05s
✅ BASH shellcheck 7 0 0.25s
✅ BASH shfmt 7 0 0 0.29s
✅ COPYPASTE jscpd yes no 2.04s
✅ DOCKERFILE hadolint 102 0 17.78s
✅ JSON eslint-plugin-jsonc 20 0 0 1.92s
✅ JSON jsonlint 18 0 4.02s
✅ JSON v8r 20 0 11.25s
⚠️ MARKDOWN markdownlint 277 0 4 4.44s
✅ MARKDOWN markdown-link-check 277 0 4.94s
✅ MARKDOWN markdown-table-formatter 277 0 0 6.7s
✅ OPENAPI spectral 1 0 0.78s
⚠️ PYTHON bandit 163 50 1.91s
✅ PYTHON black 163 0 0 3.16s
✅ PYTHON flake8 163 0 2.26s
✅ PYTHON isort 163 0 0 0.56s
✅ PYTHON mypy 163 0 89.35s
✅ PYTHON pylint 163 0 15.24s
✅ REPOSITORY git_diff yes no 0.25s
✅ REPOSITORY secretlint yes no 11.29s
⚠️ REPOSITORY semgrep yes 182 40.98s
✅ REPOSITORY trivy yes no 24.35s
✅ SPELL cspell 866 0 22.45s
✅ SPELL misspell 700 0 0 0.68s
✅ XML xmllint 3 0 0.01s
✅ YAML prettier 79 0 0 2.19s
✅ YAML v8r 22 0 25.22s
✅ YAML yamllint 80 0 1.05s

See errors details in artifact MegaLinter reports on CI Job page

@codecov-commenter
Copy link

Codecov Report

Merging #1644 (3fcf488) into main (e41ec8c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1644      +/-   ##
==========================================
+ Coverage   83.85%   83.90%   +0.04%     
==========================================
  Files         157      158       +1     
  Lines        4106     4112       +6     
==========================================
+ Hits         3443     3450       +7     
+ Misses        663      662       -1     
Impacted Files Coverage Δ
...test_megalinter/linters/makefile_checkmake_test.py 100.00% <100.00%> (ø)
megalinter/reporters/UpdatedSourcesReporter.py 91.89% <0.00%> (+2.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@nvuillam
Copy link
Member Author

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.04s
✅ BASH shellcheck 7 0 0.3s
✅ BASH shfmt 7 0 0 0.07s
✅ COPYPASTE jscpd yes no 2.16s
✅ DOCKERFILE hadolint 102 0 17.43s
✅ JSON eslint-plugin-jsonc 20 0 0 2.07s
✅ JSON jsonlint 18 0 4.59s
✅ JSON v8r 20 0 11.34s
⚠️ MARKDOWN markdownlint 277 2 4 4.47s
✅ MARKDOWN markdown-link-check 277 0 5.01s
✅ MARKDOWN markdown-table-formatter 277 2 0 6.33s
✅ OPENAPI spectral 1 0 1.0s
⚠️ PYTHON bandit 163 50 2.18s
✅ PYTHON black 163 0 0 3.15s
✅ PYTHON flake8 163 0 2.6s
✅ PYTHON isort 163 0 0 0.34s
✅ PYTHON mypy 163 0 95.1s
✅ PYTHON pylint 163 0 18.43s
⚠️ REPOSITORY devskim yes 101 1.38s
✅ REPOSITORY dustilock yes no 2.2s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY secretlint yes no 4.93s
⚠️ REPOSITORY semgrep yes 182 50.83s
✅ REPOSITORY syft yes no 2.85s
✅ REPOSITORY trivy yes no 15.06s
✅ SPELL cspell 866 0 22.74s
✅ SPELL misspell 700 2 0 0.49s
✅ XML xmllint 3 0 0.01s
✅ YAML prettier 79 0 0 2.67s
✅ YAML v8r 22 0 24.88s
✅ YAML yamllint 80 0 1.2s

See errors details in artifact MegaLinter reports on CI Job page

@nvuillam nvuillam merged commit 216f085 into main Jul 24, 2022
@nvuillam nvuillam deleted the features/makefile-linter branch July 24, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: add Makefile linter
2 participants